Commit a89d63a1 authored by Casey Dahlin's avatar Casey Dahlin Committed by David Teigland
Browse files

dlm: free socket in error exit path 



In the tcp_connect_to_sock() error exit path, the socket
allocated at the top of the function was not being freed.

Signed-off-by: default avatarCasey Dahlin <cdahlin@redhat.com>
Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
parent c78a87d0

fs/dlm/lowcomms.c

+3 −1
Original line number Diff line number Diff line
@@ -902,7 +902,7 @@ static void tcp_connect_to_sock(struct connection *con) 
	int result = -EHOSTUNREACH;

	struct sockaddr_storage saddr, src_addr;

	int addr_len;

	struct socket *sock;

	struct socket *sock = NULL;



	if (con->nodeid == 0) {

		log_print("attempt to connect sock 0 foiled");
@@ -962,6 +962,8 @@ static void tcp_connect_to_sock(struct connection *con) 
	if (con->sock) {

		sock_release(con->sock);

		con->sock = NULL;

	} else if (sock) {

		sock_release(sock);

	}

	/*

	 * Some errors are fatal and this list might need adjusting. For other