Commit a4a6afb4 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Christoph Hellwig
Browse files

scsi: Do not display buffer pointers in scsi_log_send() 



scsi_log_send() would display buffer pointer for higher logging levels.
This is not only of questionable value but also exposes kernel pointer to
userspace, which is discouraged in some setups. So drop this message
altogether.

Tested-by: default avatarRobert Elliott <elliott@hp.com>
Reviewed-by: default avatarRobert Elliott <elliott@hp.com>
Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 2dd951ec

drivers/scsi/scsi.c

+1 −8
Original line number Diff line number Diff line
@@ -531,7 +531,7 @@ void scsi_log_send(struct scsi_cmnd *cmd) 
	 *

	 * 3: same as 2

	 *

	 * 4: same as 3 plus dump extra junk

	 * 4: same as 3

	 */

	if (unlikely(scsi_logging_level)) {

		level = SCSI_LOG_LEVEL(SCSI_LOG_MLQUEUE_SHIFT,
@@ -540,13 +540,6 @@ void scsi_log_send(struct scsi_cmnd *cmd) 
			scmd_printk(KERN_INFO, cmd,

				    "Send: scmd 0x%p\n", cmd);

			scsi_print_command(cmd);

			if (level > 3) {

				printk(KERN_INFO "buffer = 0x%p, bufflen = %d,"

				       " queuecommand 0x%p\n",

					scsi_sglist(cmd), scsi_bufflen(cmd),

					cmd->device->host->hostt->queuecommand);



			}

		}

	}

}