Commit 8c9f6491 authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Kalle Valo
Browse files

mt76x2: dfs: avoid tasklet scheduling during mt76x2_dfs_init_params() 



Substitute tasklet_kill with tasklet_disable/tasklet_enable in order to
guarantee dfs tasklet can not be executed during dfs parameter
initialization

Signed-off-by: default avatarLorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 23405236

drivers/net/wireless/mediatek/mt76/mt76x2_dfs.c

+0 −1
Original line number Diff line number Diff line
@@ -460,7 +460,6 @@ void mt76x2_dfs_init_params(struct mt76x2_dev *dev) 
{

	struct cfg80211_chan_def *chandef = &dev->mt76.chandef;



	tasklet_kill(&dev->dfs_pd.dfs_tasklet);

	if (chandef->chan->flags & IEEE80211_CHAN_RADAR) {

		mt76x2_dfs_set_bbp_params(dev);

		/* enable debug mode */

drivers/net/wireless/mediatek/mt76/mt76x2_main.c

+2 −0
Original line number Diff line number Diff line
@@ -127,6 +127,7 @@ mt76x2_set_channel(struct mt76x2_dev *dev, struct cfg80211_chan_def *chandef) 
	mt76_set_channel(&dev->mt76);



	tasklet_disable(&dev->pre_tbtt_tasklet);

	tasklet_disable(&dev->dfs_pd.dfs_tasklet);

	cancel_delayed_work_sync(&dev->cal_work);



	mt76x2_mac_stop(dev, true);
@@ -139,6 +140,7 @@ mt76x2_set_channel(struct mt76x2_dev *dev, struct cfg80211_chan_def *chandef) 
	mt76x2_dfs_init_params(dev);



	mt76x2_mac_resume(dev);

	tasklet_enable(&dev->dfs_pd.dfs_tasklet);

	tasklet_enable(&dev->pre_tbtt_tasklet);



	return ret;