Commit 8c15d66e authored by Tetsuo Handa's avatar Tetsuo Handa Committed by Casey Schaufler
Browse files

Smack: Use GFP_KERNEL for smack_parse_opts_str(). 



Since smack_parse_opts_str() is calling match_strdup() which uses
GFP_KERNEL, it is safe to use GFP_KERNEL from kcalloc() which is
called by smack_parse_opts_str().

Signed-off-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
parent 2e4939f7

security/smack/smack_lsm.c

+2 −2
Original line number Diff line number Diff line
@@ -692,12 +692,12 @@ static int smack_parse_opts_str(char *options, 
		}

	}



	opts->mnt_opts = kcalloc(NUM_SMK_MNT_OPTS, sizeof(char *), GFP_ATOMIC);

	opts->mnt_opts = kcalloc(NUM_SMK_MNT_OPTS, sizeof(char *), GFP_KERNEL);

	if (!opts->mnt_opts)

		goto out_err;



	opts->mnt_opts_flags = kcalloc(NUM_SMK_MNT_OPTS, sizeof(int),

			GFP_ATOMIC);

			GFP_KERNEL);

	if (!opts->mnt_opts_flags) {

		kfree(opts->mnt_opts);

		goto out_err;