Commit 8432ebd6 authored by Rajan Vaja's avatar Rajan Vaja Committed by Kalle Valo
Browse files

hostap: Use memdup_user() to reuse code 



Fix coccicheck warning which recommends to
use memdup_user() instead of reimplementing its
code.

This patch fixes below coccicheck warnings:

drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3044:9-16: WARNING
opportunity for memdup_user
drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3806:9-16: WARNING
opportunity for memdup_user

Signed-off-by: default avatarRajan Vaja <rajan.vaja@gmail.com>
Reviewed-by: default avatarJulian Calaby <julian.calaby@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent c2da9133

drivers/net/wireless/intersil/hostap/hostap_ioctl.c

+6 −14
Original line number Diff line number Diff line
@@ -3041,13 +3041,9 @@ static int prism2_ioctl_priv_download(local_info_t *local, struct iw_point *p) 
	    p->length > 1024 || !p->pointer)

		return -EINVAL;



	param = kmalloc(p->length, GFP_KERNEL);

	if (param == NULL)

		return -ENOMEM;



	if (copy_from_user(param, p->pointer, p->length)) {

		ret = -EFAULT;

		goto out;

	param = memdup_user(p->pointer, p->length);

	if (IS_ERR(param)) {

		return PTR_ERR(param);

	}



	if (p->length < sizeof(struct prism2_download_param) +
@@ -3803,13 +3799,9 @@ static int prism2_ioctl_priv_hostapd(local_info_t *local, struct iw_point *p) 
	    p->length > PRISM2_HOSTAPD_MAX_BUF_SIZE || !p->pointer)

		return -EINVAL;



	param = kmalloc(p->length, GFP_KERNEL);

	if (param == NULL)

		return -ENOMEM;



	if (copy_from_user(param, p->pointer, p->length)) {

		ret = -EFAULT;

		goto out;

	param = memdup_user(p->pointer, p->length);

	if (IS_ERR(param)) {

		return PTR_ERR(param);

	}



	switch (param->cmd) {