Commit 7128ea15 authored by Himanshu Shukla's avatar Himanshu Shukla Committed by Casey Schaufler
Browse files

SMACK: Do not apply star label in smack_setprocattr hook 



Smack prohibits processes from using the star ("*") and web ("@") labels.
Checks have been added in other functions. In smack_setprocattr()
hook, only check for web ("@") label has been added and restricted
from applying web ("@") label.
Check for star ("*") label should also be added in smack_setprocattr()
hook. Return error should be "-EINVAL" not "-EPERM" as permission
is there for setting label but not the label value as star ("*") or
web ("@").

Signed-off-by: default avatarHimanshu Shukla <himanshu.sh@samsung.com>
Acked-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
parent 2097f599

security/smack/smack_lsm.c

+4 −3
Original line number Diff line number Diff line
@@ -3669,10 +3669,11 @@ static int smack_setprocattr(struct task_struct *p, char *name, 
		return PTR_ERR(skp);



	/*

	 * No process is ever allowed the web ("@") label.

	 * No process is ever allowed the web ("@") label

	 * and the star ("*") label.

	 */

	if (skp == &smack_known_web)

		return -EPERM;

	if (skp == &smack_known_web || skp == &smack_known_star)

		return -EINVAL;



	if (!smack_privileged(CAP_MAC_ADMIN)) {

		rc = -EPERM;