Commit 61034e00 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: addi_apci_2032: cleanup the s->subdev_flags 



The flags SDF_GROUND and SDF_COMMON only have meaning for analog
input/output subdevices. Remove these flags from the digital
output and timer subdevices in this driver.

The digital output subdevice does not need the SDF_READABLE flag.
Remove it.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c0c3c7df

drivers/staging/comedi/drivers/addi_apci_2032.c

+2 −3
Original line number Diff line number Diff line
@@ -59,8 +59,7 @@ static int apci2032_auto_attach(struct comedi_device *dev, 
	/* Initialize the digital output subdevice */

	s = &dev->subdevices[0];

	s->type = COMEDI_SUBD_DO;

	s->subdev_flags =

		SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;

	s->subdev_flags = SDF_WRITEABLE;

	s->n_chan = 32;

	s->maxdata = 1;

	s->range_table = &range_digital;
@@ -71,7 +70,7 @@ static int apci2032_auto_attach(struct comedi_device *dev, 
	/* Initialize the watchdog subdevice */

	s = &dev->subdevices[1];

	s->type = COMEDI_SUBD_TIMER;

	s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;

	s->subdev_flags = SDF_WRITEABLE;

	s->n_chan = 1;

	s->maxdata = 0;

	s->len_chanlist = 1;