Commit 5e33b719 authored by roel kluin's avatar roel kluin Committed by David S. Miller
Browse files

pcnet32: Read buffer overflow 



An `options[cards_found]' that equals `sizeof(options_mapping)' is already beyond
the array.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 418372b0

drivers/net/pcnet32.c

+1 −1
Original line number Diff line number Diff line
@@ -1839,7 +1839,7 @@ pcnet32_probe1(unsigned long ioaddr, int shared, struct pci_dev *pdev) 
	lp->chip_version = chip_version;

	lp->msg_enable = pcnet32_debug;

	if ((cards_found >= MAX_UNITS)

	    || (options[cards_found] > sizeof(options_mapping)))

	    || (options[cards_found] >= sizeof(options_mapping)))

		lp->options = PCNET32_PORT_ASEL;

	else

		lp->options = options_mapping[options[cards_found]];