Commit 5d601255 authored by liang xie's avatar liang xie Committed by Theodore Ts'o
Browse files

ext4: add missing BUFFER_TRACE before ext4_journal_get_write_access 



Make them more consistently

Signed-off-by: default avatarxieliang <xieliang@xiaomi.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent c8b459f4

fs/ext4/extents.c

+1 −0
Original line number Diff line number Diff line
@@ -143,6 +143,7 @@ static int ext4_ext_get_access(handle_t *handle, struct inode *inode, 
{

	if (path->p_bh) {

		/* path points to block */

		BUFFER_TRACE(path->p_bh, "get_write_access");

		return ext4_journal_get_write_access(handle, path->p_bh);

	}

	/* path points to leaf/index in inode body */

fs/ext4/file.c

+1 −0
Original line number Diff line number Diff line
@@ -244,6 +244,7 @@ static int ext4_file_open(struct inode * inode, struct file * filp) 
			handle = ext4_journal_start_sb(sb, EXT4_HT_MISC, 1);

			if (IS_ERR(handle))

				return PTR_ERR(handle);

			BUFFER_TRACE(sbi->s_sbh, "get_write_access");

			err = ext4_journal_get_write_access(handle, sbi->s_sbh);

			if (err) {

				ext4_journal_stop(handle);

fs/ext4/inline.c

+5 −0
Original line number Diff line number Diff line
@@ -264,6 +264,7 @@ static int ext4_create_inline_data(handle_t *handle, 
	if (error)

		return error;



	BUFFER_TRACE(is.iloc.bh, "get_write_access");

	error = ext4_journal_get_write_access(handle, is.iloc.bh);

	if (error)

		goto out;
@@ -347,6 +348,7 @@ static int ext4_update_inline_data(handle_t *handle, struct inode *inode, 
	if (error == -ENODATA)

		goto out;



	BUFFER_TRACE(is.iloc.bh, "get_write_access");

	error = ext4_journal_get_write_access(handle, is.iloc.bh);

	if (error)

		goto out;
@@ -424,6 +426,7 @@ static int ext4_destroy_inline_data_nolock(handle_t *handle, 
	if (error)

		goto out;



	BUFFER_TRACE(is.iloc.bh, "get_write_access");

	error = ext4_journal_get_write_access(handle, is.iloc.bh);

	if (error)

		goto out;
@@ -1007,6 +1010,7 @@ static int ext4_add_dirent_to_inline(handle_t *handle, 
	if (err)

		return err;



	BUFFER_TRACE(iloc->bh, "get_write_access");

	err = ext4_journal_get_write_access(handle, iloc->bh);

	if (err)

		return err;
@@ -1669,6 +1673,7 @@ int ext4_delete_inline_entry(handle_t *handle, 
				EXT4_MIN_INLINE_DATA_SIZE;

	}



	BUFFER_TRACE(bh, "get_write_access");

	err = ext4_journal_get_write_access(handle, bh);

	if (err)

		goto out;

fs/ext4/inode.c

+3 −0
Original line number Diff line number Diff line
@@ -922,6 +922,7 @@ int do_journal_get_write_access(handle_t *handle, 
	 */

	if (dirty)

		clear_buffer_dirty(bh);

	BUFFER_TRACE(bh, "get write access");

	ret = ext4_journal_get_write_access(handle, bh);

	if (!ret && dirty)

		ret = ext4_handle_dirty_metadata(handle, NULL, bh);
@@ -1769,6 +1770,7 @@ static int __ext4_journalled_writepage(struct page *page, 
	BUG_ON(!ext4_handle_valid(handle));



	if (inline_data) {

		BUFFER_TRACE(inode_bh, "get write access");

		ret = ext4_journal_get_write_access(handle, inode_bh);



		err = ext4_handle_dirty_metadata(handle, inode, inode_bh);
@@ -4412,6 +4414,7 @@ static int ext4_do_update_inode(handle_t *handle, 
		err = rc;

	ext4_clear_inode_state(inode, EXT4_STATE_NEW);

	if (set_large_file) {

		BUFFER_TRACE(EXT4_SB(sb)->s_sbh, "get write access");

		err = ext4_journal_get_write_access(handle, EXT4_SB(sb)->s_sbh);

		if (err)

			goto out_brelse;

fs/ext4/mballoc.c

+2 −0
Original line number Diff line number Diff line
@@ -2874,6 +2874,7 @@ ext4_mb_mark_diskspace_used(struct ext4_allocation_context *ac, 
	if (!bitmap_bh)

		goto out_err;



	BUFFER_TRACE(bitmap_bh, "getting write access");

	err = ext4_journal_get_write_access(handle, bitmap_bh);

	if (err)

		goto out_err;
@@ -2886,6 +2887,7 @@ ext4_mb_mark_diskspace_used(struct ext4_allocation_context *ac, 
	ext4_debug("using block group %u(%d)\n", ac->ac_b_ex.fe_group,

			ext4_free_group_clusters(sb, gdp));



	BUFFER_TRACE(gdp_bh, "get_write_access");

	err = ext4_journal_get_write_access(handle, gdp_bh);

	if (err)

		goto out_err;