Commit 57c2b0dd authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Mark Brown
Browse files

spi: pic32: fixup wait_for_completion_timeout return handling 



wait_for_completion_timeout returns unsigned long not int so the check for
<= 0 should be == 0 here.

Signed-off-by: default avatarNicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 523d939e

drivers/spi/spi-pic32.c

+3 −2
Original line number Diff line number Diff line
@@ -507,6 +507,7 @@ static int pic32_spi_one_transfer(struct spi_master *master, 
{

	struct pic32_spi *pic32s;

	bool dma_issued = false;

	unsigned long timeout;

	int ret;



	pic32s = spi_master_get_devdata(master);
@@ -553,8 +554,8 @@ static int pic32_spi_one_transfer(struct spi_master *master, 
	}



	/* wait for completion */

	ret = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ);

	if (ret <= 0) {

	timeout = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ);

	if (timeout == 0) {

		dev_err(&spi->dev, "wait error/timedout\n");

		if (dma_issued) {

			dmaengine_terminate_all(master->dma_rx);