Commit 49c19400 authored by Jean Delvare's avatar Jean Delvare Committed by Greg Kroah-Hartman
Browse files

sysfs: sysfs_chmod_file's attr can be const 



sysfs_chmod_file doesn't change the attribute it operates on, so this
attribute can be marked const.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 3317fad5

fs/sysfs/file.c

+2 −1
Original line number Diff line number Diff line
@@ -593,7 +593,8 @@ EXPORT_SYMBOL_GPL(sysfs_add_file_to_group); 
 * @mode: file permissions.

 *

 */

int sysfs_chmod_file(struct kobject *kobj, struct attribute *attr, mode_t mode)

int sysfs_chmod_file(struct kobject *kobj, const struct attribute *attr,

		     mode_t mode)

{

	struct sysfs_dirent *sd;

	struct iattr newattrs;

include/linux/sysfs.h

+3 −3
Original line number Diff line number Diff line
@@ -136,8 +136,8 @@ int __must_check sysfs_create_file(struct kobject *kobj, 
				   const struct attribute *attr);

int __must_check sysfs_create_files(struct kobject *kobj,

				   const struct attribute **attr);

int __must_check sysfs_chmod_file(struct kobject *kobj, struct attribute *attr,

				  mode_t mode);

int __must_check sysfs_chmod_file(struct kobject *kobj,

				  const struct attribute *attr, mode_t mode);

void sysfs_remove_file(struct kobject *kobj, const struct attribute *attr);

void sysfs_remove_files(struct kobject *kobj, const struct attribute **attr);
@@ -225,7 +225,7 @@ static inline int sysfs_create_files(struct kobject *kobj, 
}



static inline int sysfs_chmod_file(struct kobject *kobj,

				   struct attribute *attr, mode_t mode)

				   const struct attribute *attr, mode_t mode)

{

	return 0;

}