Commit 44068d59 authored by Stephan Mueller's avatar Stephan Mueller Committed by Herbert Xu
Browse files

crypto: DRBG - initialize SGL only once 



An SGL to be initialized only once even when its buffers are written
to several times.

Signed-off-by: default avatarStephan Mueller <smueller@chronox.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 0d8da104

crypto/drbg.c

+2 −3
Original line number Diff line number Diff line
@@ -1749,17 +1749,16 @@ static int drbg_kcapi_sym_ctr(struct drbg_state *drbg, 
			      u8 *inbuf, u32 inlen,

			      u8 *outbuf, u32 outlen)

{

	struct scatterlist sg_in;

	struct scatterlist sg_in, sg_out;

	int ret;



	sg_init_one(&sg_in, inbuf, inlen);

	sg_init_one(&sg_out, drbg->outscratchpad, DRBG_OUTSCRATCHLEN);



	while (outlen) {

		u32 cryptlen = min3(inlen, outlen, (u32)DRBG_OUTSCRATCHLEN);

		struct scatterlist sg_out;



		/* Output buffer may not be valid for SGL, use scratchpad */

		sg_init_one(&sg_out, drbg->outscratchpad, cryptlen);

		skcipher_request_set_crypt(drbg->ctr_req, &sg_in, &sg_out,

					   cryptlen, drbg->V);

		ret = crypto_skcipher_encrypt(drbg->ctr_req);