Commit 43ab8502 authored by roel kluin's avatar roel kluin Committed by David S. Miller
Browse files

ax25: unsigned cannot be less than 0 in ax25_ctl_ioctl() 



struct ax25_ctl_struct member `arg' is unsigned and cannot be less
than 0.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ac958154

net/ax25/af_ax25.c

+3 −4
Original line number Diff line number Diff line
@@ -369,6 +369,9 @@ static int ax25_ctl_ioctl(const unsigned int cmd, void __user *arg) 
	if (ax25_ctl.digi_count > AX25_MAX_DIGIS)

		return -EINVAL;



	if (ax25_ctl.arg > ULONG_MAX / HZ && ax25_ctl.cmd != AX25_KILL)

		return -EINVAL;



	digi.ndigi = ax25_ctl.digi_count;

	for (k = 0; k < digi.ndigi; k++)

		digi.calls[k] = ax25_ctl.digi_addr[k];
@@ -418,14 +421,10 @@ static int ax25_ctl_ioctl(const unsigned int cmd, void __user *arg) 
		break;



	case AX25_T3:

		if (ax25_ctl.arg < 0)

			goto einval_put;

		ax25->t3 = ax25_ctl.arg * HZ;

		break;



	case AX25_IDLE:

		if (ax25_ctl.arg < 0)

			goto einval_put;

		ax25->idle = ax25_ctl.arg * 60 * HZ;

		break;