Commit 38c70b27 authored by Alan Cox's avatar Alan Cox Committed by Greg Kroah-Hartman
Browse files

tty: Push the bkl down a bit in the hangup code 



We know that the redirect field is handled via its own locking in all
places

Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent f18f9498

drivers/char/tty_io.c

+2 −2
Original line number Diff line number Diff line
@@ -505,8 +505,6 @@ static void do_tty_hangup(struct work_struct *work) 
	if (!tty)

		return;



	/* inuse_filps is protected by the single kernel lock */

	lock_kernel();



	spin_lock(&redirect_lock);

	if (redirect && redirect->private_data == tty) {
@@ -515,6 +513,8 @@ static void do_tty_hangup(struct work_struct *work) 
	}

	spin_unlock(&redirect_lock);



	/* inuse_filps is protected by the single kernel lock */

	lock_kernel();

	check_tty_count(tty, "do_tty_hangup");

	file_list_lock();

	/* This breaks for file handles being sent over AF_UNIX sockets ? */