Commit 332e0d13 authored by Pan Bian's avatar Pan Bian Committed by Alexandre Belloni
Browse files

rtc: gemini: add return value validation 



Function devm_ioremap() will return a NULL pointer if it fails to remap
IO address, and its return value should be validated before it is used.
However, in function gemini_rtc_probe(), its return value is not
checked. This may result in bad memory access bugs on future access,
e.g. calling the function gemini_rtc_read_time().

Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Acked-by: default avatarHans Ulli Kroll <ulli.kroll@googlemail.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 75892900

drivers/rtc/rtc-gemini.c

+2 −0
Original line number Diff line number Diff line
@@ -139,6 +139,8 @@ static int gemini_rtc_probe(struct platform_device *pdev) 


	rtc->rtc_base = devm_ioremap(dev, res->start,

				     resource_size(res));

	if (!rtc->rtc_base)

		return -ENOMEM;



	ret = devm_request_irq(dev, rtc->rtc_irq, gemini_rtc_interrupt,

			       IRQF_SHARED, pdev->name, dev);