Commit 2fd527b7 authored Dec 12, 2018 by Petr Machata Committed by David S. Miller Dec 12, 2018

net: ndo_bridge_setlink: Add extack



Drivers may not be able to implement a VLAN addition or reconfiguration.
In those cases it's desirable to explain to the user that it was
rejected (and why).

To that end, add extack argument to ndo_bridge_setlink. Adapt all users
to that change.

Following patches will use the new argument in the bridge driver.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 351cbde9

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -9618,7 +9618,7 @@ static int bnxt_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
		}

		static int bnxt_bridge_setlink(struct net_device dev, struct nlmsghdr nlh,
		u16 flags)
		u16 flags, struct netlink_ext_ack *extack)
		{
		struct bnxt *bp = netdev_priv(dev);
		struct nlattr attr, br_spec;

drivers/net/ethernet/emulex/benet/be_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4955,7 +4955,7 @@ int be_load_fw(struct be_adapter adapter, u8 fw_file)
		}

		static int be_ndo_bridge_setlink(struct net_device dev, struct nlmsghdr nlh,
		u16 flags)
		u16 flags, struct netlink_ext_ack *extack)
		{
		struct be_adapter *adapter = netdev_priv(dev);
		struct nlattr attr, br_spec;

drivers/net/ethernet/intel/i40e/i40e_main.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -11685,6 +11685,7 @@ static int i40e_ndo_fdb_add(struct ndmsg ndm, struct nlattr tb[],
		* @dev: the netdev being configured
		* @nlh: RTNL message
		* @flags: bridge flags
		* @extack: netlink extended ack
		*
		* Inserts a new hardware bridge if not already created and
		* enables the bridging mode requested (VEB or VEPA). If the
		@@ -11697,7 +11698,8 @@ static int i40e_ndo_fdb_add(struct ndmsg ndm, struct nlattr tb[],
		**/
		static int i40e_ndo_bridge_setlink(struct net_device *dev,
		struct nlmsghdr *nlh,
		u16 flags)
		u16 flags,
		struct netlink_ext_ack *extack)
		{
		struct i40e_netdev_priv *np = netdev_priv(dev);
		struct i40e_vsi *vsi = np->vsi;

drivers/net/ethernet/intel/ice/ice_main.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -3624,6 +3624,7 @@ static int ice_vsi_update_bridge_mode(struct ice_vsi *vsi, u16 bmode)
		* @dev: the netdev being configured
		* @nlh: RTNL message
		* @flags: bridge setlink flags
		* @extack: netlink extended ack
		*
		* Sets the bridge mode (VEB/VEPA) of the switch to which the netdev (VSI) is
		* hooked up to. Iterates through the PF VSI list and sets the loopback mode (if
		@@ -3632,7 +3633,7 @@ static int ice_vsi_update_bridge_mode(struct ice_vsi *vsi, u16 bmode)
		*/
		static int
		ice_bridge_setlink(struct net_device dev, struct nlmsghdr nlh,
		u16 __always_unused flags)
		u16 __always_unused flags, struct netlink_ext_ack *extack)
		{
		struct ice_netdev_priv *np = netdev_priv(dev);
		struct ice_pf *pf = np->vsi->back;

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -9979,7 +9979,8 @@ static int ixgbe_configure_bridge_mode(struct ixgbe_adapter *adapter,
		}

		static int ixgbe_ndo_bridge_setlink(struct net_device *dev,
		struct nlmsghdr *nlh, u16 flags)
		struct nlmsghdr *nlh, u16 flags,
		struct netlink_ext_ack *extack)
		{
		struct ixgbe_adapter *adapter = netdev_priv(dev);
		struct nlattr attr, br_spec;