Commit 1e0ba006 authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by David S. Miller
Browse files

atm: Bad locking on br2684_devs modifications. 



The list_del happens under read-locked devs_lock.

Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 65e41136

net/atm/br2684.c

+2 −2
Original line number Diff line number Diff line
@@ -346,9 +346,9 @@ static void br2684_push(struct atm_vcc *atmvcc, struct sk_buff *skb) 
		/* skb==NULL means VCC is being destroyed */

		br2684_close_vcc(brvcc);

		if (list_empty(&brdev->brvccs)) {

			read_lock(&devs_lock);

			write_lock_irq(&devs_lock);

			list_del(&brdev->br2684_devs);

			read_unlock(&devs_lock);

			write_unlock_irq(&devs_lock);

			unregister_netdev(net_dev);

		}

		return;