Commit 1d967195 authored by Baolin Wang's avatar Baolin Wang Committed by Vinod Koul
Browse files

dmaengine: mmp_tdma: Let the core do the device node validation 



Let the DMA engine core do the device node validation instead of drivers.

Signed-off-by: default avatarBaolin Wang <baolin.wang@linaro.org>
Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent c88ba7b9

drivers/dma/mmp_tdma.c

+2 −8
Original line number Diff line number Diff line
@@ -586,18 +586,12 @@ static int mmp_tdma_chan_init(struct mmp_tdma_device *tdev, 
}



struct mmp_tdma_filter_param {

	struct device_node *of_node;

	unsigned int chan_id;

};



static bool mmp_tdma_filter_fn(struct dma_chan *chan, void *fn_param)

{

	struct mmp_tdma_filter_param *param = fn_param;

	struct mmp_tdma_chan *tdmac = to_mmp_tdma_chan(chan);

	struct dma_device *pdma_device = tdmac->chan.device;



	if (pdma_device->dev->of_node != param->of_node)

		return false;



	if (chan->chan_id != param->chan_id)

		return false;
@@ -615,13 +609,13 @@ static struct dma_chan *mmp_tdma_xlate(struct of_phandle_args *dma_spec, 
	if (dma_spec->args_count != 1)

		return NULL;



	param.of_node = ofdma->of_node;

	param.chan_id = dma_spec->args[0];



	if (param.chan_id >= TDMA_CHANNEL_NUM)

		return NULL;



	return dma_request_channel(mask, mmp_tdma_filter_fn, &param);

	return __dma_request_channel(&mask, mmp_tdma_filter_fn, &param,

				     ofdma->of_node);

}



static const struct of_device_id mmp_tdma_dt_ids[] = {