Commit 13c2bede authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Mauro Carvalho Chehab
Browse files

media: radio: wl1273: add check on core->write() return value 



Check return value from call to core->write(), so in case of
error print error message, jump to goto label fail and eventually
return.

Addresses-Coverity-ID: 1226943

Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarHans Verkuil <hansverk@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 0a0c1b82

drivers/media/radio/radio-wl1273.c

+13 −2
Original line number Diff line number Diff line
@@ -610,10 +610,21 @@ static int wl1273_fm_start(struct wl1273_device *radio, int new_mode) 
			}

		}



		if (radio->rds_on)

		if (radio->rds_on) {

			r = core->write(core, WL1273_RDS_DATA_ENB, 1);

		else

			if (r) {

				dev_err(dev, "%s: RDS_DATA_ENB ON fails\n",

					__func__);

				goto fail;

			}

		} else {

			r = core->write(core, WL1273_RDS_DATA_ENB, 0);

			if (r) {

				dev_err(dev, "%s: RDS_DATA_ENB OFF fails\n",

					__func__);

				goto fail;

			}

		}

	} else {

		dev_warn(dev, "%s: Illegal mode.\n", __func__);

	}