Commit ff8f63da authored by Robert Foley's avatar Robert Foley Committed by Alex Bennée
Browse files

tests: Disable select tests under TSan, which hit TSan issue. 

Disable a few tests under CONFIG_TSAN, which
run into a known TSan issue that results in a hang.
https://github.com/google/sanitizers/issues/1116



The disabled tests under TSan include all the qtests as well as
the test-char, test-qga, and test-qdev-global-props.

Signed-off-by: default avatarRobert Foley <robert.foley@linaro.org>
Reviewed-by: default avatarEmilio G. Cota <cota@braap.org>
Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Message-Id: <20200609200738.445-14-robert.foley@linaro.org>
Message-Id: <20200612190237.30436-17-alex.bennee@linaro.org>
parent 3b6882bd

tests/Makefile.include

+7 −2
Original line number Diff line number Diff line
@@ -55,7 +55,6 @@ SYSEMU_TARGET_LIST := $(subst -softmmu.mak,,$(notdir \ 


check-unit-y += tests/check-qdict$(EXESUF)

check-unit-y += tests/check-block-qdict$(EXESUF)

check-unit-$(CONFIG_SOFTMMU) += tests/test-char$(EXESUF)

check-unit-y += tests/check-qnum$(EXESUF)

check-unit-y += tests/check-qstring$(EXESUF)

check-unit-y += tests/check-qlist$(EXESUF)
@@ -108,7 +107,6 @@ check-unit-y += tests/test-qht$(EXESUF) 
check-unit-y += tests/test-qht-par$(EXESUF)

check-unit-y += tests/test-bitops$(EXESUF)

check-unit-y += tests/test-bitcnt$(EXESUF)

check-unit-$(CONFIG_SOFTMMU) += tests/test-qdev-global-props$(EXESUF)

check-unit-y += tests/check-qom-interface$(EXESUF)

check-unit-y += tests/check-qom-proplist$(EXESUF)

check-unit-y += tests/test-qemu-opts$(EXESUF)
@@ -123,9 +121,16 @@ check-speed-$(CONFIG_BLOCK) += tests/benchmark-crypto-cipher$(EXESUF) 
check-unit-$(CONFIG_BLOCK) += tests/test-crypto-secret$(EXESUF)

check-unit-$(call land,$(CONFIG_BLOCK),$(CONFIG_GNUTLS)) += tests/test-crypto-tlscredsx509$(EXESUF)

check-unit-$(call land,$(CONFIG_BLOCK),$(CONFIG_GNUTLS)) += tests/test-crypto-tlssession$(EXESUF)

ifndef CONFIG_TSAN

# Some tests: test-char, test-qdev-global-props, and test-qga,

# are not runnable under TSan due to a known issue.

# https://github.com/google/sanitizers/issues/1116

check-unit-$(CONFIG_SOFTMMU) += tests/test-char$(EXESUF)

check-unit-$(CONFIG_SOFTMMU) += tests/test-qdev-global-props$(EXESUF)

ifneq (,$(findstring qemu-ga,$(TOOLS)))

check-unit-$(call land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) += tests/test-qga$(EXESUF)

endif

endif

check-unit-$(CONFIG_SOFTMMU) += tests/test-timed-average$(EXESUF)

check-unit-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_INOTIFY1)) += tests/test-util-filemonitor$(EXESUF)

check-unit-$(CONFIG_SOFTMMU) += tests/test-util-sockets$(EXESUF)

tests/qtest/Makefile.include

+5 −2
Original line number Diff line number Diff line
@@ -314,12 +314,15 @@ tests/qtest/tpm-tis-device-test$(EXESUF): tests/qtest/tpm-tis-device-test.o test 
# QTest rules



TARGETS=$(patsubst %-softmmu,%, $(filter %-softmmu,$(TARGET_DIRS)))

QTEST_TARGETS =

# The qtests are not runnable (yet) under TSan due to a known issue.

# https://github.com/google/sanitizers/issues/1116

ifndef CONFIG_TSAN

ifeq ($(CONFIG_POSIX),y)

QTEST_TARGETS = $(TARGETS)

check-qtest-y=$(foreach TARGET,$(TARGETS), $(check-qtest-$(TARGET)-y:%=tests/qtest/%$(EXESUF)))

check-qtest-y += $(check-qtest-generic-y:%=tests/qtest/%$(EXESUF))

else

QTEST_TARGETS =

endif

endif



qtest-obj-y = tests/qtest/libqtest.o $(test-util-obj-y)