Commit ff82fab7 authored Mar 20, 2018 by Paolo Bonzini

chardev-socket: remove useless if



This trips Coverity, which believes the subsequent qio_channel_create_watch
can dereference a NULL pointer.  In reality, tcp_chr_connect's callers
all have s->ioc properly initialized, since they are all rooted at
tcp_chr_new_client.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 87f963be

chardev/char-socket.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -550,12 +550,10 @@ static void tcp_chr_connect(void *opaque)
		s->is_listen, s->is_telnet);

		s->connected = 1;
		if (s->ioc) {
		chr->gsource = io_add_watch_poll(chr, s->ioc,
		tcp_chr_read_poll,
		tcp_chr_read,
		chr, chr->gcontext);
		}

		s->hup_source = qio_channel_create_watch(s->ioc, G_IO_HUP);
		g_source_set_callback(s->hup_source, (GSourceFunc)tcp_chr_hup,