Commit fdf235ba authored by Eric Blake's avatar Eric Blake
Browse files

tests: Silence false positive warning on generated test name



Running 'make check' on rawhide with gcc 8.0.1 fails:

tests/test-visitor-serialization.c: In function 'main':
tests/test-visitor-serialization.c:1127:34: error: '/primitives/' directive writing 12 bytes into a region of size between 1 and 128 [-Werror=format-overflow=]

The warning is a false positive (we have two buffers of size 128,
so yes, if we FULLY used the first buffer, then sprint'ing it into
the second will overflow the second).  But in practice, our first
buffer will not be longer than "/visitor/serialization/String",
so sizing it smaller is enough to let gcc see that we don't
overflow the second.

Signed-off-by: default avatarEric Blake <eblake@redhat.com>
Message-Id: <20180323204341.1501664-1-eblake@redhat.com>
Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
parent fa15cf8b
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1115,7 +1115,7 @@ static const SerializeOps visitors[] = {

static void add_visitor_type(const SerializeOps *ops)
{
    char testname_prefix[128];
    char testname_prefix[32];
    char testname[128];
    TestArgs *args;
    int i = 0;