Commit fcc8ef17 authored by David Hildenbrand's avatar David Hildenbrand Committed by David Gibson
Browse files

spapr: no need to verify the node 



The node property can always be queried and the value has already been
verified in pc_dimm_realize().

Acked-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent bfda32a8

hw/ppc/spapr.c

+2 −8
Original line number Diff line number Diff line
@@ -3578,14 +3578,8 @@ static void spapr_machine_device_plug(HotplugHandler *hotplug_dev, 
            error_setg(errp, "Memory hotplug not supported for this machine");

            return;

        }

        node = object_property_get_uint(OBJECT(dev), PC_DIMM_NODE_PROP, errp);

        if (*errp) {

            return;

        }

        if (node < 0 || node >= MAX_NODES) {

            error_setg(errp, "Invaild node %d", node);

            return;

        }

        node = object_property_get_uint(OBJECT(dev), PC_DIMM_NODE_PROP,

                                        &error_abort);



        spapr_memory_plug(hotplug_dev, dev, node, errp);

    } else if (object_dynamic_cast(OBJECT(dev), TYPE_SPAPR_CPU_CORE)) {