Commit fcb9e9f2 authored by David Hildenbrand's avatar David Hildenbrand Committed by Cornelia Huck
Browse files

s390x/tcg: Fix parts of IEEE exception handling 



Many things are wrong and some parts cannot be fixed yet. Fix what we
can fix easily and add two FIXMEs:

The fpc flags are not updated in case an exception is actually injected.
Inexact exceptions have to be handled separately, as they are the only
exceptions that can coexist with underflows and overflows.

I reread the horribly complicated chapters in the PoP at least 5 times
and hope I got it right.

For references:
- z14 PoP, 9-18, "IEEE Exceptions"
- z14 PoP, 19-9, Figure 19-8

Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Message-Id: <20190218122710.23639-5-david@redhat.com>
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent 4b70fc54

target/s390x/fpu_helper.c

+32 −6
Original line number Diff line number Diff line
@@ -63,14 +63,40 @@ static void handle_exceptions(CPUS390XState *env, uintptr_t retaddr) 
    env->fpu_status.float_exception_flags = 0;

    s390_exc = s390_softfloat_exc_to_ieee(qemu_exc);



    /* Install the exceptions that we raised.  */

    env->fpc |= s390_exc << 16;

    /*

     * FIXME:

     * 1. Right now, all inexact conditions are inidicated as

     *    "truncated" (0) and never as "incremented" (1) in the DXC.

     * 2. Only traps due to invalid/divbyzero are suppressing. Other traps

     *    are completing, meaning the target register has to be written!

     *    This, however will mean that we have to write the register before

     *    triggering the trap - impossible right now.

     */



    /* Send signals for enabled exceptions.  */

    s390_exc &= env->fpc >> 24;

    if (s390_exc) {

    /*

     * invalid/divbyzero cannot coexist with other conditions.

     * overflow/underflow however can coexist with inexact, we have to

     * handle it separatly.

     */

    if (s390_exc & ~S390_IEEE_MASK_INEXACT) {

        if (s390_exc & ~S390_IEEE_MASK_INEXACT & env->fpc >> 24) {

            /* trap condition - inexact reported along */

            tcg_s390_data_exception(env, s390_exc, retaddr);

        }

        /* nontrap condition - inexact handled differently */

        env->fpc |= (s390_exc & ~S390_IEEE_MASK_INEXACT) << 16;

    }



    /* inexact handling */

    if (s390_exc & S390_IEEE_MASK_INEXACT) {

        /* trap condition - overflow/underflow _not_ reported along */

        if (s390_exc & S390_IEEE_MASK_INEXACT & env->fpc >> 24) {

            tcg_s390_data_exception(env, s390_exc & S390_IEEE_MASK_INEXACT,

                                    retaddr);

        }

        /* nontrap condition */

        env->fpc |= (s390_exc & S390_IEEE_MASK_INEXACT) << 16;

    }

}



static inline int float_comp_to_cc(CPUS390XState *env, int float_compare)