Commit fc50ff06 authored by zhanghailiang's avatar zhanghailiang Committed by Michael S. Tsirkin
Browse files

pc-dimm: Don't check dimm->node when there is non-NUMA config 



It should not break memory hotplug feature if there is non-NUMA option.

This patch would also allow to use pc-dimm as replacement for initial memory
for non-NUMA configs.

Note: After this patch, the memory hotplug can work normally for Linux guest OS
when there is non-NUMA option and NUMA option. But not support Windows guest OS
to hotplug memory with no-NUMA config, actully, it's Windows limitation.

Reviewed-By: default avatarIgor Mammedov <imammedo@redhat.com>
Signed-off-by: default avatarzhanghailiang <zhang.zhanghailiang@huawei.com>
Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 22b80e85

hw/mem/pc-dimm.c

+1 −1
Original line number Diff line number Diff line
@@ -252,7 +252,7 @@ static void pc_dimm_realize(DeviceState *dev, Error **errp) 
        error_setg(errp, "'" PC_DIMM_MEMDEV_PROP "' property is not set");

        return;

    }

    if (dimm->node >= nb_numa_nodes) {

    if ((nb_numa_nodes > 0) && (dimm->node >= nb_numa_nodes)) {

        error_setg(errp, "'DIMM property " PC_DIMM_NODE_PROP " has value %"

                   PRIu32 "' which exceeds the number of numa nodes: %d",

                   dimm->node, nb_numa_nodes);