Commit fbd5c4c0 authored by Murilo Opsfelder Araujo's avatar Murilo Opsfelder Araujo Committed by Jeff Cody
Browse files

block/ssh: fix possible segmentation fault when .desc is not null-terminated 

This patch prevents a possible segmentation fault when .desc members are checked
against NULL.

The ssh_runtime_opts was added by commit
8a6a8089 ("block/ssh: Use QemuOpts for runtime
options").

This fix was inspired by
http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg00883.html

.

Fixes: 8a6a8089 ("block/ssh: Use QemuOpts for runtime options")
Cc: Max Reitz <mreitz@redhat.com>
Cc: Eric Blake <eblake@redhat.com>
Signed-off-by: default avatarMurilo Opsfelder Araujo <muriloo@linux.vnet.ibm.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
parent b0563195

block/ssh.c

+1 −0
Original line number Diff line number Diff line
@@ -556,6 +556,7 @@ static QemuOptsList ssh_runtime_opts = { 
            .type = QEMU_OPT_STRING,

            .help = "Defines how and what to check the host key against",

        },

        { /* end of list */ }

    },

};