Commit fb6649f1 authored by Mark Cave-Ayland's avatar Mark Cave-Ayland Committed by David Gibson
Browse files

adb: fix read reg 3 byte ordering 



According to the Apple ADB documentation, register 3 is a 2-byte register
with the device address in the first byte, and the handler ID in the second
byte.

This is currently the opposite away to which QEMU returns them so switch the
order around.

Signed-off-by: default avatarMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 8f55ac13

hw/input/adb-kbd.c

+2 −2
Original line number Diff line number Diff line
@@ -290,8 +290,8 @@ static int adb_kbd_request(ADBDevice *d, uint8_t *obuf, 
            olen = 2;

            break;

        case 3:

            obuf[0] = d->handler;

            obuf[1] = d->devaddr;

            obuf[0] = d->devaddr;

            obuf[1] = d->handler;

            olen = 2;

            break;

        }

hw/input/adb-mouse.c

+2 −2
Original line number Diff line number Diff line
@@ -172,8 +172,8 @@ static int adb_mouse_request(ADBDevice *d, uint8_t *obuf, 
        case 1:

            break;

        case 3:

            obuf[0] = d->handler;

            obuf[1] = d->devaddr;

            obuf[0] = d->devaddr;

            obuf[1] = d->handler;

            olen = 2;

            break;

        }