Commit fb3b4e6d authored by Eduardo Habkost's avatar Eduardo Habkost
Browse files

basevm: Call logging.basicConfig() 



Just setting level=DEBUG when debug is enabled is not enough: we
need to set up a log handler if we want debug messages generated
using logging.getLogger(...).debug() to be printed.

This was not a problem before because logging.debug() calls
logging.basicConfig() implicitly, but it's safer to not rely on
that.

Cc: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Fam Zheng <famz@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170927130339.21444-4-ehabkost@redhat.com>
Reviewed-by: default avatarDaniel P. Berrange <berrange@redhat.com>
Reviewed-by: default avatarFam Zheng <famz@redhat.com>
Reviewed-by: default avatarLukáš Doktor <ldoktor@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent 43851b5b

tests/vm/basevm.py

+2 −2
Original line number Diff line number Diff line
@@ -227,8 +227,8 @@ def main(vmcls): 
        if not argv and not args.build_qemu and not args.build_image:

            print "Nothing to do?"

            return 1

        if args.debug:

            logging.getLogger().setLevel(logging.DEBUG)

        logging.basicConfig(level=(logging.DEBUG if args.debug

                                   else logging.WARN))

        vm = vmcls(debug=args.debug, vcpus=args.jobs)

        if args.build_image:

            if os.path.exists(args.image) and not args.force: