Commit fb1a66bc authored by Jon Emil Jahren's avatar Jon Emil Jahren Committed by Stefan Hajnoczi
Browse files

tracetool: Update argument format regex to non-greedy star 



Using the greedy star matching, arguments like "...%"PRIx64 caused issues
for functions with multiple PRI formats.

The issue was only seen with the ust backend, as it is the only one
using the format regex.

The result for many functions was that the arguments coming after the
greedy star end was left out of the tracepoint, and in some cases some
of the arguments that was traced had the wrong format.

Signed-off-by: default avatarJon Emil Jahren <jonemilj@gmail.com>
Message-id: 20180129041648.30884-2-jonemilj@gmail.com
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent e5ecc287

scripts/tracetool/__init__.py

+3 −2
Original line number Diff line number Diff line
@@ -261,8 +261,9 @@ class Event(object): 
                                          self.name,

                                          self.args,

                                          fmt)



    _FMT = re.compile("(%[\d\.]*\w+|%.*PRI\S+)")

    # Star matching on PRI is dangerous as one might have multiple

    # arguments with that format, hence the non-greedy version of it.

    _FMT = re.compile("(%[\d\.]*\w+|%.*?PRI\S+)")



    def formats(self):

        """List conversion specifiers in the argument print format string."""