Commit fb0e843a authored by Alexey Kardashevskiy's avatar Alexey Kardashevskiy Committed by Andreas Färber
Browse files

xics-kvm: Fix reset function 



Currently interrupt priorities are set to 0 (highest) at the very
beginning of the guest execution which is not correct and makes the guest
produce random interrupt error messages such as:
"Interrupt 0x1001 (real) is invalid, disabling it".
This also prevents interrupt states from correct migration.

This initializes priority to 0xFF as the emulated XICS does.

Suggested-by: default avatarPaul Mackerras <paulus@samba.org>
Signed-off-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
parent 8f3babb7

hw/intc/xics_kvm.c

+10 −1
Original line number Diff line number Diff line
@@ -269,7 +269,16 @@ static void ics_kvm_set_irq(void *opaque, int srcno, int val) 


static void ics_kvm_reset(DeviceState *dev)

{

    ics_set_kvm_state(ICS(dev), 1);

    ICSState *ics = ICS(dev);

    int i;



    memset(ics->irqs, 0, sizeof(ICSIRQState) * ics->nr_irqs);

    for (i = 0; i < ics->nr_irqs; i++) {

        ics->irqs[i].priority = 0xff;

        ics->irqs[i].saved_priority = 0xff;

    }



    ics_set_kvm_state(ics, 1);

}



static void ics_kvm_realize(DeviceState *dev, Error **errp)