Commit f945b84a authored Jul 22, 2019 by Thomas Huth

tests/libqtest: Remove unused function hmp()



No test is using hmp() anymore, and since this function uses the disliked
global_qtest variable, we should also make sure that nobody adds new code
with this function again. qtest_hmp() should be used instead.

Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20190813093047.27948-4-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>

parent 2380d31e

tests/libqtest.c

+0 −11

Original line number	Diff line number	Diff line
		@@ -1130,17 +1130,6 @@ void qmp_assert_success(const char *fmt, ...)
		qobject_unref(response);
		}

		char hmp(const char fmt, ...)
		{
		va_list ap;
		char *ret;

		va_start(ap, fmt);
		ret = qtest_vhmp(global_qtest, fmt, ap);
		va_end(ap);
		return ret;
		}

		bool qtest_big_endian(QTestState *s)
		{
		return s->big_endian;

tests/libqtest.h

+0 −10

Original line number	Diff line number	Diff line
		@@ -687,16 +687,6 @@ static inline void qmp_eventwait(const char *event)
		return qtest_qmp_eventwait(global_qtest, event);
		}

		/**
		* hmp:
		* @fmt...: HMP command to send to QEMU, formats arguments like sprintf().
		*
		* Send HMP command to QEMU via QMP's human-monitor-command.
		*
		* Returns: the command's output. The caller should g_free() it.
		*/
		char hmp(const char fmt, ...) GCC_FMT_ATTR(1, 2);

		/**
		* get_irq:
		* @num: Interrupt to observe.