Commit f9125e3a authored by Yi Min Zhao's avatar Yi Min Zhao Committed by Cornelia Huck
Browse files

s390x/pci: use the right pal and pba in reg_ioat() 



When registering ioat, pba should be comprised of leftmost 52 bits and
rightmost 12 binary zeros, and pal should be comprised of leftmost 52
bits and right most 12 binary ones. The lower 12 bits of words 5 and 7
of the FIB are ignored by the facility. Let's fixup this.

Reviewed-by: default avatarPierre Morel <pmorel@linux.vnet.ibm.com>
Signed-off-by: default avatarYi Min Zhao <zyimin@linux.vnet.ibm.com>
Message-Id: <20180205072258.5968-4-zyimin@linux.vnet.ibm.com>
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent b3f05d8c

hw/s390x/s390-pci-inst.c

+2 −0
Original line number Diff line number Diff line
@@ -865,6 +865,8 @@ static int reg_ioat(CPUS390XState *env, S390PCIIOMMU *iommu, ZpciFib fib, 
    uint8_t dt = (g_iota >> 2) & 0x7;

    uint8_t t = (g_iota >> 11) & 0x1;



    pba &= ~0xfff;

    pal |= 0xfff;

    if (pba > pal || pba < ZPCI_SDMA_ADDR || pal > ZPCI_EDMA_ADDR) {

        s390_program_interrupt(env, PGM_OPERAND, 6, ra);

        return -EINVAL;