Commit f8c45c65 authored by Paolo Bonzini's avatar Paolo Bonzini
Browse files

target/i386: use multiple CPU AddressSpaces 



This speeds up SMM switches.  Later on it may remove the need to take
the BQL, and it may also allow to reuse code between TCG and KVM.

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent c8bc83a4

target/i386/cpu.c

+10 −5
Original line number Diff line number Diff line
@@ -3239,7 +3239,7 @@ static void x86_cpu_machine_done(Notifier *n, void *unused) 
        cpu->smram = g_new(MemoryRegion, 1);

        memory_region_init_alias(cpu->smram, OBJECT(cpu), "smram",

                                 smram, 0, 1ull << 32);

        memory_region_set_enabled(cpu->smram, false);

        memory_region_set_enabled(cpu->smram, true);

        memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->smram, 1);

    }

}
@@ -3619,7 +3619,9 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) 


#ifndef CONFIG_USER_ONLY

    if (tcg_enabled()) {

        AddressSpace *newas = g_new(AddressSpace, 1);

        AddressSpace *as_normal = address_space_init_shareable(cs->memory,

                                                               "cpu-memory");

        AddressSpace *as_smm = g_new(AddressSpace, 1);



        cpu->cpu_as_mem = g_new(MemoryRegion, 1);

        cpu->cpu_as_root = g_new(MemoryRegion, 1);
@@ -3635,9 +3637,11 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) 
                                 get_system_memory(), 0, ~0ull);

        memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem, 0);

        memory_region_set_enabled(cpu->cpu_as_mem, true);

        address_space_init(newas, cpu->cpu_as_root, "CPU");

        cs->num_ases = 1;

        cpu_address_space_init(cs, newas, 0);

        address_space_init(as_smm, cpu->cpu_as_root, "CPU");



        cs->num_ases = 2;

        cpu_address_space_init(cs, as_normal, 0);

        cpu_address_space_init(cs, as_smm, 1);



        /* ... SMRAM with higher priority, linked from /machine/smram.  */

        cpu->machine_done.notify = x86_cpu_machine_done;
@@ -4053,6 +4057,7 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data) 
#ifdef CONFIG_USER_ONLY

    cc->handle_mmu_fault = x86_cpu_handle_mmu_fault;

#else

    cc->asidx_from_attrs = x86_asidx_from_attrs;

    cc->get_memory_mapping = x86_cpu_get_memory_mapping;

    cc->get_phys_page_debug = x86_cpu_get_phys_page_debug;

    cc->write_elf64_note = x86_cpu_write_elf64_note;

target/i386/cpu.h

+10 −1
Original line number Diff line number Diff line
@@ -1451,6 +1451,16 @@ int x86_cpu_handle_mmu_fault(CPUState *cpu, vaddr addr, 
void x86_cpu_set_a20(X86CPU *cpu, int a20_state);



#ifndef CONFIG_USER_ONLY

static inline int x86_asidx_from_attrs(CPUState *cs, MemTxAttrs attrs)

{

    return !!attrs.secure;

}



static inline AddressSpace *cpu_addressspace(CPUState *cs, MemTxAttrs attrs)

{

    return cpu_get_address_space(cs, cpu_asidx_from_attrs(cs, attrs));

}



uint8_t x86_ldub_phys(CPUState *cs, hwaddr addr);

uint32_t x86_lduw_phys(CPUState *cs, hwaddr addr);

uint32_t x86_ldl_phys(CPUState *cs, hwaddr addr);
@@ -1653,7 +1663,6 @@ void do_interrupt_x86_hardirq(CPUX86State *env, int intno, int is_hw); 


/* smm_helper.c */

void do_smm_enter(X86CPU *cpu);

void cpu_smm_update(X86CPU *cpu);



/* apic.c */

void cpu_report_tpr_access(CPUX86State *env, TPRAccess access);

target/i386/helper.c

+27 −27
Original line number Diff line number Diff line
@@ -1403,89 +1403,89 @@ uint8_t x86_ldub_phys(CPUState *cs, hwaddr addr) 
{

    X86CPU *cpu = X86_CPU(cs);

    CPUX86State *env = &cpu->env;

    MemTxAttrs attrs = cpu_get_mem_attrs(env);

    AddressSpace *as = cpu_addressspace(cs, attrs);



    return address_space_ldub(cs->as, addr,

                              cpu_get_mem_attrs(env),

                              NULL);

    return address_space_ldub(as, addr, attrs, NULL);

}



uint32_t x86_lduw_phys(CPUState *cs, hwaddr addr)

{

    X86CPU *cpu = X86_CPU(cs);

    CPUX86State *env = &cpu->env;

    MemTxAttrs attrs = cpu_get_mem_attrs(env);

    AddressSpace *as = cpu_addressspace(cs, attrs);



    return address_space_lduw(cs->as, addr,

                              cpu_get_mem_attrs(env),

                              NULL);

    return address_space_lduw(as, addr, attrs, NULL);

}



uint32_t x86_ldl_phys(CPUState *cs, hwaddr addr)

{

    X86CPU *cpu = X86_CPU(cs);

    CPUX86State *env = &cpu->env;

    MemTxAttrs attrs = cpu_get_mem_attrs(env);

    AddressSpace *as = cpu_addressspace(cs, attrs);



    return address_space_ldl(cs->as, addr,

                             cpu_get_mem_attrs(env),

                             NULL);

    return address_space_ldl(as, addr, attrs, NULL);

}



uint64_t x86_ldq_phys(CPUState *cs, hwaddr addr)

{

    X86CPU *cpu = X86_CPU(cs);

    CPUX86State *env = &cpu->env;

    MemTxAttrs attrs = cpu_get_mem_attrs(env);

    AddressSpace *as = cpu_addressspace(cs, attrs);



    return address_space_ldq(cs->as, addr,

                             cpu_get_mem_attrs(env),

                             NULL);

    return address_space_ldq(as, addr, attrs, NULL);

}



void x86_stb_phys(CPUState *cs, hwaddr addr, uint8_t val)

{

    X86CPU *cpu = X86_CPU(cs);

    CPUX86State *env = &cpu->env;

    MemTxAttrs attrs = cpu_get_mem_attrs(env);

    AddressSpace *as = cpu_addressspace(cs, attrs);



    address_space_stb(cs->as, addr, val,

                      cpu_get_mem_attrs(env),

                      NULL);

    address_space_stb(as, addr, val, attrs, NULL);

}



void x86_stl_phys_notdirty(CPUState *cs, hwaddr addr, uint32_t val)

{

    X86CPU *cpu = X86_CPU(cs);

    CPUX86State *env = &cpu->env;

    MemTxAttrs attrs = cpu_get_mem_attrs(env);

    AddressSpace *as = cpu_addressspace(cs, attrs);



    address_space_stl_notdirty(cs->as, addr, val,

                               cpu_get_mem_attrs(env),

                               NULL);

    address_space_stl_notdirty(as, addr, val, attrs, NULL);

}



void x86_stw_phys(CPUState *cs, hwaddr addr, uint32_t val)

{

    X86CPU *cpu = X86_CPU(cs);

    CPUX86State *env = &cpu->env;

    MemTxAttrs attrs = cpu_get_mem_attrs(env);

    AddressSpace *as = cpu_addressspace(cs, attrs);



    address_space_stw(cs->as, addr, val,

                      cpu_get_mem_attrs(env),

                      NULL);

    address_space_stw(as, addr, val, attrs, NULL);

}



void x86_stl_phys(CPUState *cs, hwaddr addr, uint32_t val)

{

    X86CPU *cpu = X86_CPU(cs);

    CPUX86State *env = &cpu->env;

    MemTxAttrs attrs = cpu_get_mem_attrs(env);

    AddressSpace *as = cpu_addressspace(cs, attrs);



    address_space_stl(cs->as, addr, val,

                      cpu_get_mem_attrs(env),

                      NULL);

    address_space_stl(as, addr, val, attrs, NULL);

}



void x86_stq_phys(CPUState *cs, hwaddr addr, uint64_t val)

{

    X86CPU *cpu = X86_CPU(cs);

    CPUX86State *env = &cpu->env;

    MemTxAttrs attrs = cpu_get_mem_attrs(env);

    AddressSpace *as = cpu_addressspace(cs, attrs);



    address_space_stq(cs->as, addr, val,

                      cpu_get_mem_attrs(env),

                      NULL);

    address_space_stq(as, addr, val, attrs, NULL);

}

#endif

target/i386/machine.c

+0 −4
Original line number Diff line number Diff line
@@ -274,10 +274,6 @@ static int cpu_post_load(void *opaque, int version_id) 
        cpu_x86_update_dr7(env, dr7);

    }

    tlb_flush(cs);



    if (tcg_enabled()) {

        cpu_smm_update(cpu);

    }

    return 0;

}

target/i386/smm_helper.c

+0 −18
Original line number Diff line number Diff line
@@ -43,19 +43,6 @@ void helper_rsm(CPUX86State *env) 
#define SMM_REVISION_ID 0x00020000

#endif



/* Called with iothread lock taken */

void cpu_smm_update(X86CPU *cpu)

{

    CPUX86State *env = &cpu->env;

    bool smm_enabled = (env->hflags & HF_SMM_MASK);



    g_assert(qemu_mutex_iothread_locked());



    if (cpu->smram) {

        memory_region_set_enabled(cpu->smram, smm_enabled);

    }

}



void do_smm_enter(X86CPU *cpu)

{

    CPUX86State *env = &cpu->env;
@@ -73,7 +60,6 @@ void do_smm_enter(X86CPU *cpu) 
    } else {

        env->hflags2 |= HF2_NMI_MASK;

    }

    cpu_smm_update(cpu);



    sm_state = env->smbase + 0x8000;
@@ -338,10 +324,6 @@ void helper_rsm(CPUX86State *env) 
    env->hflags2 &= ~HF2_SMM_INSIDE_NMI_MASK;

    env->hflags &= ~HF_SMM_MASK;



    qemu_mutex_lock_iothread();

    cpu_smm_update(cpu);

    qemu_mutex_unlock_iothread();



    qemu_log_mask(CPU_LOG_INT, "SMM: after RSM\n");

    log_cpu_state_mask(CPU_LOG_INT, CPU(cpu), CPU_DUMP_CCOP);

}