Commit f8278c7d authored Feb 06, 2019 by Marc-André Lureau

char-pty: remove the check for connection on write



This doesn't help much compared to the 1 second poll PTY
timer. I can't think of a use case where this would help.

However, we can simplify the code around chr_write(): the write lock
is no longer needed for other char-pty callbacks (see following
patch).

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20190206174328.9736-6-marcandre.lureau@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

parent 64c3f266

chardev/char-pty.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -129,13 +129,9 @@ static int char_pty_chr_write(Chardev chr, const uint8_t buf, int len)
		{
		PtyChardev *s = PTY_CHARDEV(chr);

		if (!s->connected) {
		/* guest sends data, check for (re-)connect */
		pty_chr_update_read_handler_locked(chr);
		if (!s->connected) {
		return len;
		}
		}
		return io_channel_send(s->ioc, buf, len);
		}