Commit f693fe6e authored by Michael Roth's avatar Michael Roth
Browse files

qga: guest-get-memory-blocks shouldn't fail for unexposed memory blocks 



Some guests don't expose memory blocks via sysfs at all. This
shouldn't be a failure, instead just return an empty list. For
other access failures we still report an error.

Signed-off-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
parent 8a0b5421

qga/commands-posix.c

+8 −2
Original line number Diff line number Diff line
@@ -2213,8 +2213,14 @@ GuestMemoryBlockList *qmp_guest_get_memory_blocks(Error **errp) 


    dp = opendir("/sys/devices/system/memory/");

    if (!dp) {

        /* it's ok if this happens to be a system that doesn't expose

         * memory blocks via sysfs, but otherwise we should report

         * an error

         */

        if (errno != ENOENT) {

            error_setg_errno(errp, errno, "Can't open directory"

                             "\"/sys/devices/system/memory/\"\n");

        }

        return NULL;

    }