Commit f68ec837 authored by Andreas Färber's avatar Andreas Färber Committed by Stefan Hajnoczi
Browse files

ide: Set BSY bit during FLUSH 



The implementation of the ATA FLUSH command invokes a flush at the block
layer, which may on raw files on POSIX entail a synchronous fdatasync().
This may in some cases take so long that the SLES 11 SP1 guest driver
reports I/O errors and filesystems get corrupted or remounted read-only.

Avoid this by setting BUSY_STAT, so that the guest is made aware we are
in the middle of an operation and no ATA commands are attempted to be
processed concurrently.

Addresses BNC#637297.

Suggested-by: default avatarGonglei (Arei) <arei.gonglei@huawei.com>
Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent c27d5656

hw/ide/core.c

+1 −0
Original line number Diff line number Diff line
@@ -814,6 +814,7 @@ void ide_flush_cache(IDEState *s) 
        return;

    }



    s->status |= BUSY_STAT;

    bdrv_acct_start(s->bs, &s->acct, 0, BDRV_ACCT_FLUSH);

    bdrv_aio_flush(s->bs, ide_flush_cb, s);

}