Commit f60f5e80 authored by Wei Yang's avatar Wei Yang Committed by Michael S. Tsirkin
Browse files

pc-dimm: use same mechanism for [get|set]_addr 



[get|set]_addr are two counterpart to access PCDIMMDevice.addr.

Since we have already set up a property PC_DIMM_ADDR_PROP for this
field and use this mechanism in set_addr, it would be more proper to use
the same mechanism in get_addr.

This patch uses object_property_get_uint() to replace the direct memory
access to make [get|set]_addr with the same mechanism.

Signed-off-by: default avatarWei Yang <richardw.yang@linux.intel.com>

Message-Id: <20190211064629.20186-1-richardw.yang@linux.intel.com>
Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 503bb0b9

hw/mem/pc-dimm.c

+1 −3
Original line number Diff line number Diff line
@@ -204,9 +204,7 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice *dimm, Error **errp) 


static uint64_t pc_dimm_md_get_addr(const MemoryDeviceState *md)

{

    const PCDIMMDevice *dimm = PC_DIMM(md);



    return dimm->addr;

    return object_property_get_uint(OBJECT(md), PC_DIMM_ADDR_PROP, &error_abort);

}



static void pc_dimm_md_set_addr(MemoryDeviceState *md, uint64_t addr,