Commit f5cf94cd authored by Alex Williamson's avatar Alex Williamson Committed by Cornelia Huck
Browse files

vfio-ccw: Test vfio_set_irq_signaling() return value 



Coverity doesn't like that most callers of vfio_set_irq_signaling() check
the return value and doesn't understand the equivalence of testing the
error pointer instead.  Test the return value consistently.

Reported-by: Coverity (CID 1402783)
Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Message-Id: <156209642116.14915.9598593247782519613.stgit@gimli.home>
Reviewed-by: default avatarEric Auger <eric.auger@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent 3a1acf5d

hw/vfio/ccw.c

+2 −3
Original line number Diff line number Diff line
@@ -327,9 +327,8 @@ static void vfio_ccw_unregister_io_notifier(VFIOCCWDevice *vcdev) 
{

    Error *err = NULL;



    vfio_set_irq_signaling(&vcdev->vdev, VFIO_CCW_IO_IRQ_INDEX, 0,

                           VFIO_IRQ_SET_ACTION_TRIGGER, -1, &err);

    if (err) {

    if (vfio_set_irq_signaling(&vcdev->vdev, VFIO_CCW_IO_IRQ_INDEX, 0,

                               VFIO_IRQ_SET_ACTION_TRIGGER, -1, &err)) {

        error_reportf_err(err, VFIO_MSG_PREFIX, vcdev->vdev.name);

    }