Commit f5bdd781 authored by Peter Maydell's avatar Peter Maydell Committed by Michael Tokarev
Browse files

gdbstub: Use qemu_set_cloexec() 



Use the utility routine qemu_set_cloexec() rather than
manually calling fcntl(). This lets us drop the #ifndef _WIN32
guards and also means Coverity doesn't complain that we're
ignoring the fcntl error return (CID 1005665, CID 1005667).

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent d29eb678

gdbstub.c

+2 −6
Original line number Diff line number Diff line
@@ -1828,9 +1828,7 @@ static void gdb_accept(void) 
            perror("accept");

            return;

        } else if (fd >= 0) {

#ifndef _WIN32

            fcntl(fd, F_SETFD, FD_CLOEXEC);

#endif

            qemu_set_cloexec(fd);

            break;

        }

    }
@@ -1857,9 +1855,7 @@ static int gdbserver_open(int port) 
        perror("socket");

        return -1;

    }

#ifndef _WIN32

    fcntl(fd, F_SETFD, FD_CLOEXEC);

#endif

    qemu_set_cloexec(fd);



    socket_set_fast_reuse(fd);