Commit f58f2559 authored by Thomas Huth's avatar Thomas Huth Committed by Peter Maydell
Browse files

hw/arm/digic: Mark device with user_creatable = false 



QEMU currently shows some unexpected behavior when the user trys to
do a "device_add digic" on an unrelated ARM machine like integratorcp
in "-nographic" mode (the device_add command does not immediately
return to the monitor prompt), and trying to "device_del" the device
later results in a "qemu/qdev-monitor.c:872:qdev_unplug: assertion
failed: (hotplug_ctrl)" error condition.
Looking at the realize function of the device, it uses serial_hds
directly and this means that the device can not be added a second
time, so let's simply mark it with "user_creatable = false" now.

Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 469f3da4

hw/arm/digic.c

+2 −0
Original line number Diff line number Diff line
@@ -101,6 +101,8 @@ static void digic_class_init(ObjectClass *oc, void *data) 
    DeviceClass *dc = DEVICE_CLASS(oc);



    dc->realize = digic_realize;

    /* Reason: Uses serial_hds in the realize function --> not usable twice */

    dc->user_creatable = false;

}



static const TypeInfo digic_type_info = {