Commit f4f2539b authored by Changlong Xie's avatar Changlong Xie Committed by Max Reitz
Browse files

block/replication: Clarify 'top-id' parameter usage 



The replication driver only supports the 'top-id' parameter for the
secondary side; it must not be supplied for the primary side.

Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarChanglong Xie <xiecl.fnst@cn.fujitsu.com>
Message-id: 1476247808-15646-1-git-send-email-xiecl.fnst@cn.fujitsu.com
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent 6d3f4049

block/replication.c

+5 −0
Original line number Diff line number Diff line
@@ -101,6 +101,11 @@ static int replication_open(BlockDriverState *bs, QDict *options, 


    if (!strcmp(mode, "primary")) {

        s->mode = REPLICATION_MODE_PRIMARY;

        top_id = qemu_opt_get(opts, REPLICATION_TOP_ID);

        if (top_id) {

            error_setg(&local_err, "The primary side does not support option top-id");

            goto fail;

        }

    } else if (!strcmp(mode, "secondary")) {

        s->mode = REPLICATION_MODE_SECONDARY;

        top_id = qemu_opt_get(opts, REPLICATION_TOP_ID);

qapi/block-core.json

+2 −1
Original line number Diff line number Diff line
@@ -2197,7 +2197,8 @@ 
# @mode: the replication mode

#

# @top-id: #optional In secondary mode, node name or device ID of the root

#          node who owns the replication node chain. Ignored in primary mode.

#          node who owns the replication node chain. Must not be given in

#          primary mode.

#

# Since: 2.8

##