Commit f3a508eb authored by panny060's avatar panny060 Committed by Peter Maydell
Browse files

armv7m_systick: delay timer_new to avoid memleaks 



There is a memory leak when we call 'device_list_properties' with typename = armv7m_systick. It's easy to reproduce as follow:

  virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments": {"typename": "armv7m_systick"}}'

This patch delay timer_new to fix this memleaks.

Reported-by: default avatarEuler Robot <euler.robot@huawei.com>
Signed-off-by: default avatarPan Nengyuan <pannengyuan@huawei.com>
Message-id: 20200205070659.22488-2-pannengyuan@huawei.com
Cc: qemu-arm@nongnu.org
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent fa3236a9

hw/timer/armv7m_systick.c

+6 −0
Original line number Diff line number Diff line
@@ -216,6 +216,11 @@ static void systick_instance_init(Object *obj) 
    memory_region_init_io(&s->iomem, obj, &systick_ops, s, "systick", 0xe0);

    sysbus_init_mmio(sbd, &s->iomem);

    sysbus_init_irq(sbd, &s->irq);

}



static void systick_realize(DeviceState *dev, Error **errp)

{

    SysTickState *s = SYSTICK(dev);

    s->timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, systick_timer_tick, s);

}
@@ -238,6 +243,7 @@ static void systick_class_init(ObjectClass *klass, void *data) 


    dc->vmsd = &vmstate_systick;

    dc->reset = systick_reset;

    dc->realize = systick_realize;

}



static const TypeInfo armv7m_systick_info = {