Commit f2eb665a authored by Leon Alrae's avatar Leon Alrae
Browse files

hw/mips_itu: fix off-by-one reported by Coverity 



Fix off-by-one error in ITC Tag read.

Remove the switch as we just want to check if index is in valid range
rather than test against list of values.

Signed-off-by: default avatarLeon Alrae <leon.alrae@imgtec.com>
parent ead5268f

hw/misc/mips_itu.c

+3 −8
Original line number Diff line number Diff line
@@ -66,18 +66,13 @@ static uint64_t itc_tag_read(void *opaque, hwaddr addr, unsigned size) 
{

    MIPSITUState *tag = (MIPSITUState *)opaque;

    uint64_t index = addr >> 3;

    uint64_t ret = 0;



    switch (index) {

    case 0 ... ITC_ADDRESSMAP_NUM:

        ret = tag->ITCAddressMap[index];

        break;

    default:

    if (index >= ITC_ADDRESSMAP_NUM) {

        qemu_log_mask(LOG_GUEST_ERROR, "Read 0x%" PRIx64 "\n", addr);

        break;

        return 0;

    }



    return ret;

    return tag->ITCAddressMap[index];

}



static void itc_reconfigure(MIPSITUState *tag)