Commit f22356d9 authored by Max Reitz's avatar Max Reitz
Browse files

qemu-img: Fix options leakage in img_rebase() 



img_rebase() can leak a QDict in two occasions.  Fix it.

Coverity: CID 1401416
Fixes: d16699b6
Fixes: 330c7295
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Message-id: 20190528195338.12376-1-mreitz@redhat.com
Reviewed-by: default avatarJohn Snow <jsnow@redhat.com>
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent 549fb880

qemu-img.c

+3 −0
Original line number Diff line number Diff line
@@ -3350,6 +3350,7 @@ static int img_rebase(int argc, char **argv) 
                                                             out_baseimg,

                                                             &local_err);

            if (local_err) {

                qobject_unref(options);

                error_reportf_err(local_err,

                                  "Could not resolve backing filename: ");

                ret = -1;
@@ -3362,7 +3363,9 @@ static int img_rebase(int argc, char **argv) 
             */

            prefix_chain_bs = bdrv_find_backing_image(bs, out_real_path);

            if (prefix_chain_bs) {

                qobject_unref(options);

                g_free(out_real_path);



                blk_new_backing = blk_new(qemu_get_aio_context(),

                                          BLK_PERM_CONSISTENT_READ,

                                          BLK_PERM_ALL);