Commit f20e6f8c authored by Li Qiang's avatar Li Qiang Committed by Paolo Bonzini
Browse files

spice-char: fix segfault in char_spice_finalize 



In 'qemu_chr_open_spice_vmc' if the 'psubtype' is NULL, it will
call 'char_spice_finalize'. But as the SpiceChardev is not inserted
in the 'spice_chars' list, the 'QLIST_REMOVE' will cause a segfault.
Add a detect to avoid it.

Signed-off-by: default avatarLi Qiang <liqiang6-s@360.cn>
Message-Id: <1487665107-88004-1-git-send-email-liqiang6-s@360.cn>
Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarLi Qiang <liq3ea@gmail.com>
parent f6f99b48

spice-qemu-char.c

+4 −1
Original line number Diff line number Diff line
@@ -215,7 +215,10 @@ static void char_spice_finalize(Object *obj) 
    SpiceChardev *s = SPICE_CHARDEV(obj);



    vmc_unregister_interface(s);



    if (s->next.le_prev) {

        QLIST_REMOVE(s, next);

    }



    g_free((char *)s->sin.subtype);

#if SPICE_SERVER_VERSION >= 0x000c02