Commit f1c29ebc authored by Thomas Huth's avatar Thomas Huth Committed by David Gibson
Browse files

target/ppc/excp_helper: Take BQL before calling cpu_interrupt() 

Since the introduction of MTTCG, using the msgsnd instruction
abort()s if being called without holding the BQL. So let's protect
that part of the code now with qemu_mutex_lock_iothread().

Buglink: https://bugs.launchpad.net/qemu/+bug/1694998


Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent d39c90f5

target/ppc/excp_helper.c

+3 −0
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ 
 * License along with this library; if not, see <http://www.gnu.org/licenses/>.

 */

#include "qemu/osdep.h"

#include "qemu/main-loop.h"

#include "cpu.h"

#include "exec/helper-proto.h"

#include "exec/exec-all.h"
@@ -1132,6 +1133,7 @@ void helper_msgsnd(target_ulong rb) 
        return;

    }



    qemu_mutex_lock_iothread();

    CPU_FOREACH(cs) {

        PowerPCCPU *cpu = POWERPC_CPU(cs);

        CPUPPCState *cenv = &cpu->env;
@@ -1141,5 +1143,6 @@ void helper_msgsnd(target_ulong rb) 
            cpu_interrupt(cs, CPU_INTERRUPT_HARD);

        }

    }

    qemu_mutex_unlock_iothread();

}

#endif