Commit efcb7e45 authored by Taimoor Mirza's avatar Taimoor Mirza Committed by Michael Tokarev
Browse files

slirp: Port redirection option behave differently on Linux and Windows 

port redirection code uses SO_REUSEADDR socket option before binding to
host port. Behavior of SO_REUSEADDR is different on Windows and Linux.
Relaunching QEMU with same host and guest port redirection values on Linux
throws error but on Windows it does not throw any error.
Problem is discussed in http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03089.html



Signed-off-by: default avatarTaimoor Mirza <tmirza@codesourcery.com>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent 4ff78e0d

slirp/socket.c

+2 −0
Original line number Diff line number Diff line
@@ -627,7 +627,9 @@ tcp_listen(Slirp *slirp, uint32_t haddr, u_int hport, uint32_t laddr, 
	addr.sin_port = hport;



	if (((s = qemu_socket(AF_INET,SOCK_STREAM,0)) < 0) ||

#ifndef _WIN32

	    (qemu_setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(int)) < 0) ||

#endif

	    (bind(s,(struct sockaddr *)&addr, sizeof(addr)) < 0) ||

	    (listen(s,1) < 0)) {

		int tmperrno = errno; /* Don't clobber the real reason we failed */