Commit ef4330c2 authored by Peter Maydell's avatar Peter Maydell Committed by Riku Voipio
Browse files

linux-user: Handle brk() attempts with very large sizes 



In do_brk(), we were inadvertently truncating the size
of a requested brk() from the guest by putting it into an
'int' variable. This meant that we would incorrectly report
success back to the guest rather than a failed allocation,
typically resulting in the guest then segfaulting. Use
abi_ulong instead.

This fixes a crash in the '31370.cc' test in the gcc libstdc++ test
suite (the test case starts by trying to allocate a very large
size and reduces the size until the allocation succeeds).

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarRiku Voipio <riku.voipio@linaro.org>
parent 005eb2ae

linux-user/syscall.c

+1 −1
Original line number Diff line number Diff line
@@ -839,7 +839,7 @@ void target_set_brk(abi_ulong new_brk) 
abi_long do_brk(abi_ulong new_brk)

{

    abi_long mapped_addr;

    int	new_alloc_size;

    abi_ulong new_alloc_size;



    DEBUGF_BRK("do_brk(" TARGET_ABI_FMT_lx ") -> ", new_brk);