Commit ef2fd6f1 authored by Markus Armbruster's avatar Markus Armbruster
Browse files

char: Make -chardev help print to stdout 



Command line help explicitly requested by the user should be printed
to stdout, not stderr.  We do elsewhere.  Adjust -chardev to match:
use qemu_printf() instead of error_printf().  Plain printf() would be
wrong because we need to print to the current monitor for "chardev-add
help".

Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190417190641.26814-14-armbru@redhat.com>
parent cdcd4361

chardev/char.c

+2 −1
Original line number Diff line number Diff line
@@ -28,6 +28,7 @@ 
#include "sysemu/sysemu.h"

#include "qemu/config-file.h"

#include "qemu/error-report.h"

#include "qemu/qemu-print.h"

#include "chardev/char.h"

#include "qapi/error.h"

#include "qapi/qapi-commands-char.h"
@@ -651,7 +652,7 @@ Chardev *qemu_chr_new_from_opts(QemuOpts *opts, GMainContext *context, 


        chardev_name_foreach(help_string_append, str);



        error_printf("Available chardev backend types: %s\n", str->str);

        qemu_printf("Available chardev backend types: %s\n", str->str);

        g_string_free(str, true);

        return NULL;

    }