Commit ed26b922 authored by Eduardo Habkost's avatar Eduardo Habkost
Browse files

numa: Fix off-by-one error at MAX_CPUMASK_BITS check 



Fix the CPU index check to ensure we don't go beyond the size of the
node_cpu bitmap.

CPU index is always less than MAX_CPUMASK_BITS, as documented at
sysemu.h:

> The following shall be true for all CPUs:
>   cpu->cpu_index < max_cpus <= MAX_CPUMASK_BITS

Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent 3e5f6234

numa.c

+2 −2
Original line number Diff line number Diff line
@@ -76,9 +76,9 @@ static void numa_node_parse(NumaNodeOptions *node, QemuOpts *opts, Error **errp) 
    }



    for (cpus = node->cpus; cpus; cpus = cpus->next) {

        if (cpus->value > MAX_CPUMASK_BITS) {

        if (cpus->value >= MAX_CPUMASK_BITS) {

            error_setg(errp, "CPU number %" PRIu16 " is bigger than %d",

                       cpus->value, MAX_CPUMASK_BITS);

                       cpus->value, MAX_CPUMASK_BITS - 1);

            return;

        }

        bitmap_set(numa_info[nodenr].node_cpu, cpus->value, 1);